Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contributor Book: Fix the link of primitive types in the "Serialization" page #2362

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Contributor Book: Fix the link of primitive types in the "Serialization" page #2362

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions contributor-book/src/project-architecture/serialization.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@ which field is a parameter or a constant, or we assume that each field implement

The second solution was chosen as it simplifies the code generation and reduces the size of the user
API. This means that the `Module` trait should be implemented by
[primitives types](./burn-core/src/module/param/primitive.rs). The following diagrams highlight the
main types and traits used in the solution.
[primitive types](https://github.com/tracel-ai/burn/blob/6d96e8d8086d2309c425f2c8a43a8246f8c454d2/crates/burn-core/src/module/param/primitive.rs).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would use the main branch for the link, otherwise it could become outdated. And for an architecture overview, that's fine not keeping up with versions.

The following diagrams highlight the main types and traits used in the solution.

<div align="center">
<h4>Module Serialization Types</h4>
Expand Down