Add properties to reduce the amount of data fetching from prometheus. #23712
+177
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amitkharb
force-pushed
the
22416
branch
4 times, most recently
from
ced471c
to
97bcf24
Compare
ebyhr
reviewed
Oct 9, 2024
| * - `prometheus.query.functions` | ||
| - Comma separated list of functions to be sent to Prometheus HTTP API as part of query. | ||
| The equivalent catalog session property is `query_functions`. | ||
| - |
There was a problem hiding this comment.
I don't think using session properties which affect query results is a good idea. We usually don't do that.
Please consider creating a table function instead: https://trino.io/docs/current/develop/table-functions.html
There was a problem hiding this comment.
Thank you @ebyhr , closing this PR, will create a new one with Table Function
|
This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To reduce the amount of data fetched by Prometheus connector, adding to new config and session properties
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: