Use AssertJ hasSize or isEmpty method #24003
Merged
+607
−608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
iceberg
ebyhr
commented
Nov 1, 2024
| assertThat(getSerializedPagePositionCount(results.getSerializedPages().get(0))).isEqualTo(1); | ||
|
|
||
| for (boolean moreResults = true; moreResults; moreResults = !results.isBufferComplete()) { | ||
| results = sqlTaskManager.getTaskResults(taskId, OUT, results.getToken() + results.getSerializedPages().size(), DataSize.of(1, Unit.MEGABYTE)).getResultsFuture().get(); | ||
| } | ||
| assertThat(results.isBufferComplete()).isTrue(); | ||
| assertThat(results.getSerializedPages().size()).isEqualTo(0); | ||
| assertThat(results.getSerializedPages()).hasSize(0); |
There was a problem hiding this comment.
Let me change to isEmpty().
ebyhr
force-pushed
the
ebi/test-has-size
branch
from
c152285
to
a93a7b5
Compare
ebyhr
commented
Nov 1, 2024
.../trino-main/src/test/java/io/trino/execution/resourcegroups/TestStochasticPriorityQueue.java
Show resolved
Hide resolved
ebyhr
changed the title
wendigo
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.