Add cosine_distance for sparse vectors #24027
Draft
+47
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mosabua
commented
Nov 4, 2024
| @@ -3457,6 +3457,25 @@ public void testCosineSimilarity() | |||
| .isNull(DOUBLE); | |||
| } | |||
|
|
|||
| @Test | |||
| public void testCosineDistance() | |||
There was a problem hiding this comment.
Not sure if we really need those tests ... in separate method or at all. Will see how they run and decide later
mosabua
commented
Nov 4, 2024
| Calculates the cosine distance between two sparse vectors: | ||
|
|
||
| ```sql | ||
| SELECT cosine_distance(MAP(ARRAY['a'], ARRAY[1.0]), MAP(ARRAY['a'], ARRAY[2.0])); |
There was a problem hiding this comment.
Have to verify this still
mosabua
force-pushed
the
sparse-distance
branch
3 times, most recently
from
82e3ad3
to
4b126bf
Compare
mosabua
force-pushed
the
sparse-distance
branch
from
4b126bf
to
cb8d293
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Still have to test this locally...
Additional context and related issues
follow up to #24005
Release notes
(*) Release notes are required, with the following suggested text: