Code cleanup in TestBigQueryAvroConnectorTest #24034
Merged
+13
−191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will avoid the code duplication in TestBigQueryAvroConnectorTest
krvikash
requested review from
ssheikin,
raunaqmorarka,
ebyhr,
Praveen2112,
vlad-lyutenko and
marcinsbd
raunaqmorarka
approved these changes
Nov 5, 2024
krvikash
force-pushed
the
krvikash/bigquery-test-refactoring
branch
from
bf89ce2
to
aa75a8e
Compare
This will avoid overriding and duplicating the projection pushdown test cases in TestBigQueryAvroConnectorTest
krvikash
force-pushed
the
krvikash/bigquery-test-refactoring
branch
from
aa75a8e
to
2abeb87
Compare
|
(added comment and added the |
marcinsbd
reviewed
Nov 5, 2024
plugin/trino-bigquery/src/test/java/io/trino/plugin/bigquery/TestBigQueryAvroConnectorTest.java
Show resolved
Hide resolved
vlad-lyutenko
approved these changes
Nov 5, 2024
|
@raunaqmorarka Could you please run this PR against secrets? |
marcinsbd
approved these changes
Nov 5, 2024
|
/test-with-secrets sha=2abeb872d2830fc55ed5b4a96ee231cfcd45d78f |
|
The CI workflow run with tests that require additional secrets has been started: https://github.com/trinodb/trino/actions/runs/11685621094 |
CI Passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
(X) This is not user-visible or is docs only, and no release notes are required.