Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back 24.05 response sending path #378

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

Tabrizian
Copy link
Member

@Tabrizian Tabrizian commented Sep 16, 2024

Before:

        "infbench_summary": {
            "Requests": 1000,
            "Requests/s": 56.781948247187536,
            "E2E Latency(s)": 17.61123087300075,
            "Avg Latency(s)": 16.54096719381794,
            "Total Input Tokens": 127000,
            "Total Output Tokens": 128000,
            "Avg. Input Tokens / Request": 127.0,
            "Avg. Output Tokens / Request": 128.0,
            "Stddev Output Tokens / Request": 0.0,
            "Input Tokens/s": 7211.307427392818,
            "Output Tokens/s": 7268.089375640005,
            "Request Issues/s": 2999.715792703272,
            "Avg TTFT(s)": 2.12225890412401,
            "Avg TPOT(s)": 0.1135331361393223
        }

After:

        "infbench_summary": {
            "Requests": 1000,
            "Requests/s": 67.5828421712087,
            "E2E Latency(s)": 14.796655007001391,
            "Avg Latency(s)": 12.20483882850504,
            "Total Input Tokens": 127000,
            "Total Output Tokens": 128000,
            "Avg. Input Tokens / Request": 127.0,
            "Avg. Output Tokens / Request": 128.0,
            "Stddev Output Tokens / Request": 0.0,
            "Input Tokens/s": 8583.020955743505,
            "Output Tokens/s": 8650.603797914713,
            "Request Issues/s": 3186.022902867275,
            "Avg TTFT(s)": 2.106685652077096,
            "Avg TPOT(s)": 0.07951301713722789
        }

24.05:

        "infbench_summary": {
            "Requests": 1000,
            "Requests/s": 66.70461264839375,
            "E2E Latency(s)": 14.991467011001077,
            "Avg Latency(s)": 13.56315037568501,
            "Total Input Tokens": 127000,
            "Total Output Tokens": 128000,
            "Avg. Input Tokens / Request": 127.0,
            "Avg. Output Tokens / Request": 128.0,
            "Stddev Output Tokens / Request": 0.0,
            "Input Tokens/s": 8471.485806346005,
            "Output Tokens/s": 8538.1904189944,
            "Request Issues/s": 2837.3298150774403,
            "Avg TTFT(s)": 2.1147114573539767,
            "Avg TPOT(s)": 0.09014518833331522
        }

@Tabrizian Tabrizian marked this pull request as draft September 16, 2024 14:26
Copy link
Contributor

@kthui kthui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments. LGTM, assuming the CI passes.

src/pb_stub.cc Outdated Show resolved Hide resolved
src/pb_stub.cc Outdated Show resolved Hide resolved
src/pb_stub.cc Outdated Show resolved Hide resolved
@Tabrizian Tabrizian marked this pull request as ready for review September 17, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants