Skip to content

fix(api): correct two Elemental field names the REST API rejects #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mikemilla merged 1 commit into from
Aug 29, 2026
Merged

fix(api): correct two Elemental field names the REST API rejects #151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions courier-java-core/src/main/kotlin/com/courier/models/ElementalImageNode.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ private constructor(
@JsonProperty("ref") @ExcludeMissing ref: JsonField<String> = JsonMissing.of(),
@JsonProperty("src") @ExcludeMissing src: JsonField<String> = JsonMissing.of(),
@JsonProperty("align") @ExcludeMissing align: JsonField<Alignment> = JsonMissing.of(),
@JsonProperty("altText") @ExcludeMissing altText: JsonField<String> = JsonMissing.of(),
@JsonProperty("alt_text") @ExcludeMissing altText: JsonField<String> = JsonMissing.of(),
@JsonProperty("border_color")
@ExcludeMissing
borderColor: JsonField<String> = JsonMissing.of(),
Expand Down Expand Up @@ -123,7 +123,7 @@ private constructor(
* @throws CourierInvalidDataException if the JSON field has an unexpected type (e.g. if the
* server responded with an unexpected value).
*/
fun altText(): Optional<String> = altText.getOptional("altText")
fun altText(): Optional<String> = altText.getOptional("alt_text")

/**
* CSS border color applied to the image. For example, `#ccc`
Expand Down Expand Up @@ -212,7 +212,7 @@ private constructor(
*
* Unlike [altText], this method doesn't throw if the JSON field has an unexpected type.
*/
@JsonProperty("altText") @ExcludeMissing fun _altText(): JsonField<String> = altText
@JsonProperty("alt_text") @ExcludeMissing fun _altText(): JsonField<String> = altText

/**
* Returns the raw JSON value of [borderColor].
Expand Down
6 changes: 3 additions & 3 deletions courier-java-core/src/main/kotlin/com/courier/models/ElementalImageNodeWithType.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ private constructor(
@JsonProperty("ref") @ExcludeMissing ref: JsonField<String> = JsonMissing.of(),
@JsonProperty("src") @ExcludeMissing src: JsonField<String> = JsonMissing.of(),
@JsonProperty("align") @ExcludeMissing align: JsonField<Alignment> = JsonMissing.of(),
@JsonProperty("altText") @ExcludeMissing altText: JsonField<String> = JsonMissing.of(),
@JsonProperty("alt_text") @ExcludeMissing altText: JsonField<String> = JsonMissing.of(),
@JsonProperty("border_color")
@ExcludeMissing
borderColor: JsonField<String> = JsonMissing.of(),
Expand Down Expand Up @@ -140,7 +140,7 @@ private constructor(
* @throws CourierInvalidDataException if the JSON field has an unexpected type (e.g. if the
* server responded with an unexpected value).
*/
fun altText(): Optional<String> = altText.getOptional("altText")
fun altText(): Optional<String> = altText.getOptional("alt_text")

/**
* CSS border color applied to the image. For example, `#ccc`
Expand Down Expand Up @@ -235,7 +235,7 @@ private constructor(
*
* Unlike [altText], this method doesn't throw if the JSON field has an unexpected type.
*/
@JsonProperty("altText") @ExcludeMissing fun _altText(): JsonField<String> = altText
@JsonProperty("alt_text") @ExcludeMissing fun _altText(): JsonField<String> = altText

/**
* Returns the raw JSON value of [borderColor].
Expand Down
8 changes: 5 additions & 3 deletions courier-java-core/src/main/kotlin/com/courier/models/ElementalQuoteNode.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ private constructor(
@JsonProperty("ref") @ExcludeMissing ref: JsonField<String> = JsonMissing.of(),
@JsonProperty("content") @ExcludeMissing content: JsonField<String> = JsonMissing.of(),
@JsonProperty("align") @ExcludeMissing align: JsonField<Alignment> = JsonMissing.of(),
@JsonProperty("borderColor")
@JsonProperty("border_color")
@ExcludeMissing
borderColor: JsonField<String> = JsonMissing.of(),
@JsonProperty("font_size") @ExcludeMissing fontSize: JsonField<String> = JsonMissing.of(),
Expand Down Expand Up @@ -122,7 +122,7 @@ private constructor(
* @throws CourierInvalidDataException if the JSON field has an unexpected type (e.g. if the
* server responded with an unexpected value).
*/
fun borderColor(): Optional<String> = borderColor.getOptional("borderColor")
fun borderColor(): Optional<String> = borderColor.getOptional("border_color")

/**
* CSS px font size for this quote block, e.g. `16px`. Overrides the size of the `text_style`
Expand Down Expand Up @@ -205,7 +205,9 @@ private constructor(
*
* Unlike [borderColor], this method doesn't throw if the JSON field has an unexpected type.
*/
@JsonProperty("borderColor") @ExcludeMissing fun _borderColor(): JsonField<String> = borderColor
@JsonProperty("border_color")
@ExcludeMissing
fun _borderColor(): JsonField<String> = borderColor

/**
* Returns the raw JSON value of [fontSize].
Expand Down
8 changes: 5 additions & 3 deletions courier-java-core/src/main/kotlin/com/courier/models/ElementalQuoteNodeWithType.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ private constructor(
@JsonProperty("ref") @ExcludeMissing ref: JsonField<String> = JsonMissing.of(),
@JsonProperty("content") @ExcludeMissing content: JsonField<String> = JsonMissing.of(),
@JsonProperty("align") @ExcludeMissing align: JsonField<Alignment> = JsonMissing.of(),
@JsonProperty("borderColor")
@JsonProperty("border_color")
@ExcludeMissing
borderColor: JsonField<String> = JsonMissing.of(),
@JsonProperty("font_size") @ExcludeMissing fontSize: JsonField<String> = JsonMissing.of(),
Expand Down Expand Up @@ -138,7 +138,7 @@ private constructor(
* @throws CourierInvalidDataException if the JSON field has an unexpected type (e.g. if the
* server responded with an unexpected value).
*/
fun borderColor(): Optional<String> = borderColor.getOptional("borderColor")
fun borderColor(): Optional<String> = borderColor.getOptional("border_color")

/**
* CSS px font size for this quote block, e.g. `16px`. Overrides the size of the `text_style`
Expand Down Expand Up @@ -227,7 +227,9 @@ private constructor(
*
* Unlike [borderColor], this method doesn't throw if the JSON field has an unexpected type.
*/
@JsonProperty("borderColor") @ExcludeMissing fun _borderColor(): JsonField<String> = borderColor
@JsonProperty("border_color")
@ExcludeMissing
fun _borderColor(): JsonField<String> = borderColor

/**
* Returns the raw JSON value of [fontSize].
Expand Down
6 changes: 3 additions & 3 deletions courier-java-core/src/test/kotlin/com/courier/models/ElementalImageNodeTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ internal class ElementalImageNodeTest {
.ref("ref")
.src("src")
.align(Alignment.CENTER)
.altText("altText")
.altText("alt_text")
.borderColor("border_color")
.borderSize("border_size")
.href("href")
Expand All @@ -34,7 +34,7 @@ internal class ElementalImageNodeTest {
assertThat(elementalImageNode.ref()).contains("ref")
assertThat(elementalImageNode.src()).isEqualTo("src")
assertThat(elementalImageNode.align()).contains(Alignment.CENTER)
assertThat(elementalImageNode.altText()).contains("altText")
assertThat(elementalImageNode.altText()).contains("alt_text")
assertThat(elementalImageNode.borderColor()).contains("border_color")
assertThat(elementalImageNode.borderSize()).contains("border_size")
assertThat(elementalImageNode.href()).contains("href")
Expand All @@ -53,7 +53,7 @@ internal class ElementalImageNodeTest {
.ref("ref")
.src("src")
.align(Alignment.CENTER)
.altText("altText")
.altText("alt_text")
.borderColor("border_color")
.borderSize("border_size")
.href("href")
Expand Down
6 changes: 3 additions & 3 deletions courier-java-core/src/test/kotlin/com/courier/models/ElementalQuoteNodeTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ internal class ElementalQuoteNodeTest {
.ref("ref")
.content("content")
.align(Alignment.CENTER)
.borderColor("borderColor")
.borderColor("border_color")
.fontSize("font_size")
.lineHeight("line_height")
.locales(
Expand All @@ -38,7 +38,7 @@ internal class ElementalQuoteNodeTest {
assertThat(elementalQuoteNode.ref()).contains("ref")
assertThat(elementalQuoteNode.content()).isEqualTo("content")
assertThat(elementalQuoteNode.align()).contains(Alignment.CENTER)
assertThat(elementalQuoteNode.borderColor()).contains("borderColor")
assertThat(elementalQuoteNode.borderColor()).contains("border_color")
assertThat(elementalQuoteNode.fontSize()).contains("font_size")
assertThat(elementalQuoteNode.lineHeight()).contains("line_height")
assertThat(elementalQuoteNode.locales())
Expand All @@ -61,7 +61,7 @@ internal class ElementalQuoteNodeTest {
.ref("ref")
.content("content")
.align(Alignment.CENTER)
.borderColor("borderColor")
.borderColor("border_color")
.fontSize("font_size")
.lineHeight("line_height")
.locales(
Expand Down
Loading