Skip to content

fix(api): correct two Elemental field names the REST API rejects #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mikemilla merged 1 commit into from
Aug 29, 2026
Merged

fix(api): correct two Elemental field names the REST API rejects #184

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/courier/types/shared/elemental_image_node.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@

from typing import Optional

from pydantic import Field as FieldInfo

from .alignment import Alignment
from .elemental_base_node import ElementalBaseNode

Expand All @@ -19,7 +17,7 @@ class ElementalImageNode(ElementalBaseNode):
align: Optional[Alignment] = None
"""The alignment of the image."""

alt_text: Optional[str] = FieldInfo(alias="altText", default=None)
alt_text: Optional[str] = None
"""Alternate text for the image."""

border_color: Optional[str] = None
Expand Down
4 changes: 1 addition & 3 deletions src/courier/types/shared/elemental_quote_node.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@

from typing import Optional

from pydantic import Field as FieldInfo

from .locales import Locales
from .alignment import Alignment
from .text_style import TextStyle
Expand All @@ -21,7 +19,7 @@ class ElementalQuoteNode(ElementalBaseNode):
align: Optional[Alignment] = None
"""Alignment of the quote."""

border_color: Optional[str] = FieldInfo(alias="borderColor", default=None)
border_color: Optional[str] = None
"""CSS border color property. For example, `#fff`"""

font_size: Optional[str] = None
Expand Down
5 changes: 2 additions & 3 deletions src/courier/types/shared_params/elemental_image_node.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,8 @@
from __future__ import annotations

from typing import Optional
from typing_extensions import Required, Annotated
from typing_extensions import Required

from ..._utils import PropertyInfo
from ..shared.alignment import Alignment
from .elemental_base_node import ElementalBaseNode

Expand All @@ -21,7 +20,7 @@ class ElementalImageNode(ElementalBaseNode, total=False):
align: Optional[Alignment]
"""The alignment of the image."""

alt_text: Annotated[Optional[str], PropertyInfo(alias="altText")]
alt_text: Optional[str]
"""Alternate text for the image."""

border_color: Optional[str]
Expand Down
5 changes: 2 additions & 3 deletions src/courier/types/shared_params/elemental_quote_node.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,9 @@
from __future__ import annotations

from typing import Optional
from typing_extensions import Required, Annotated
from typing_extensions import Required

from .locales import Locales
from ..._utils import PropertyInfo
from ..shared.alignment import Alignment
from ..shared.text_style import TextStyle
from .elemental_base_node import ElementalBaseNode
Expand All @@ -23,7 +22,7 @@ class ElementalQuoteNode(ElementalBaseNode, total=False):
align: Optional[Alignment]
"""Alignment of the quote."""

border_color: Annotated[Optional[str], PropertyInfo(alias="borderColor")]
border_color: Optional[str]
"""CSS border color property. For example, `#fff`"""

font_size: Optional[str]
Expand Down
Loading