Remove the option for an external formatter in nls #2064
Conversation
| @@ -14,10 +14,6 @@ version.workspace = true | |||
| name = "nls" | |||
| path = "src/main.rs" | |||
|
|
|||
| [features] | |||
There was a problem hiding this comment.
I'm not sure we want to remove the format feature though. I think the rationale around features right now is to leave the possibility to build a minimal nickel interpreter that can be embedded say on a server, which doesn't need to format, render markdown, etc. - so anything that isn't strictly necessary and pulls in a non trivial set of dependencies is probably better kept behind a feature gate.
There was a problem hiding this comment.
This is just the nls format feature, though. Is there a need for a minimal nls?
|
Bencher Report| Branch | 2064/merge |
| Testbed | ubuntu-latest |
⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsCLI flag.
Click to view all benchmark results
| Benchmark | Latency | nanoseconds (ns) |
|---|---|---|
| fibonacci 10 | 📈 view plot | 489,900.00 |
| pidigits 100 | 📈 view plot | 3,197,200.00 |
| product 30 | 📈 view plot | 843,750.00 |
| scalar 10 | 📈 view plot | 1,540,200.00 |
| sum 30 | 📈 view plot | 832,550.00 |
Fixes #2062.