Adds some array benchmarks to the ones tracked in CI #2067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bencher Report| Branch | 2067/merge |
| Testbed | ubuntu-latest |
⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsCLI flag.
Click to view all benchmark results
| Benchmark | Latency | nanoseconds (ns) |
|---|---|---|
| fibonacci 10 | 📈 view plot | 490,850.00 |
| foldl arrays 50 | 📈 view plot | 1,847,100.00 |
| foldl arrays 500 | 📈 view plot | 23,771,000.00 |
| foldr strings 50 | 📈 view plot | 7,122,600.00 |
| foldr strings 500 | 📈 view plot | 63,156,000.00 |
| generate normal 250 | 📈 view plot | 39,948,000.00 |
| generate normal 50 | 📈 view plot | 1,872,600.00 |
| generate normal unchecked 1000 | 📈 view plot | 57,917,000.00 |
| generate normal unchecked 200 | 📈 view plot | 2,868,200.00 |
| pidigits 100 | 📈 view plot | 3,190,900.00 |
| pipe normal 20 | 📈 view plot | 1,501,800.00 |
| pipe normal 200 | 📈 view plot | 12,208,000.00 |
| product 30 | 📈 view plot | 833,660.00 |
| scalar 10 | 📈 view plot | 1,532,300.00 |
| sum 30 | 📈 view plot | 822,670.00 |
yannham
approved these changes
Oct 10, 2024
| @@ -32,6 +35,7 @@ fn ncl_random_array(len: usize) -> String { | |||
| String::from_utf8(out).unwrap() | |||
| } | |||
|
|
|||
| #[cfg(not(feature = "benchmark-ci"))] | |||
There was a problem hiding this comment.
If the whole ncl_bench_group! is gated behind the feature, is there a reason why we need to disable individual benchmark with a #[cfg(not(...))] as well ?
There was a problem hiding this comment.
Without configuring out those things, CI failed with unused code warnings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also rewrites the sum benchmark to be (IMO) more idiomatic. It doesn't affect performance much.