Set the CLASSPATH for repl targets

[facundominguez]

No description provided.

[facundominguez]

cc @buonuomo

[facundominguez]

If you have any suggestions on how to add a test involving the repl, I could give it a try.

[facundominguez]

If you have any suggestions on how to add a test involving the repl, I could give it a try.

hm, I think I could try something similar to:
https://github.com/tweag/rules_haskell/blob/master/tests/RunTests.hs#L67-L69

[aherrmann]

Could this be carried in HaskellReplLoadInfo instead?

The idea here is that HaskellReplCollectInfo collects "load from source" and "load from binary" information separately for each target associated to the target's label. This information is then combined into HaskellReplInfo later on based on the from_source and from_binary patterns. Adding java_deps directly here changes that design. Is there a good reason to do so?

---

If I understand correctly then JARs are only compile time dependencies for targets loaded from source to interpret inline-java TH splices. With targets loaded from binary they are only runtime dependencies and so should only be made available if collect_data = True to be consistent. Does that make sense?

[facundominguez]

If I understand correctly then JARs are only compile time dependencies for targets loaded from source to interpret inline-java TH splices.

JARs are both compile and runtime dependencies in this case.

With targets loaded from binary they are only runtime dependencies and so should only be made available if collect_data = True to be consistent.

This makes sense.

[facundominguez]

I still don't understand the proposed rearrangement.

If I move java_deps to HaskellReplLoadInfo, how do I keep track of the jars that need to be added to the classpath when the target is loaded from binary?

[facundominguez]

hm, strictly speaking, the CLASSPATH doesn't need to be set when running. But it would be a convenient way to signal to the program the list of jar paths to feed to the JVM when initializing it.

This issue is related. Maybe we should handle this concern separately.

[facundominguez]

I moved java_deps to HaskellReplLoadInfo.

[aherrmann]

If I move java_deps to HaskellReplLoadInfo, how do I keep track of the jars that need to be added to the classpath when the target is loaded from binary?

Right, so they would also be needed in HaskellReplDepInfo for the runtime deps case.

[aherrmann]

hm, strictly speaking, the CLASSPATH doesn't need to be set when running. But it would be a convenient way to signal to the program the list of jar paths to feed to the JVM when initializing it.

This issue is related. Maybe we should handle this concern separately.

Oh, I remember. Yes, happy to treat this separately.

[aherrmann]

Thank you, looks good. Thank you for adding the test case!

[facundominguez]

Thanks for reviewing!