Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

various tox cleanups #182

Closed
wants to merge 23 commits into from
Closed

various tox cleanups #182

wants to merge 23 commits into from

Conversation

wsanchez
Copy link
Member

@wsanchez wsanchez commented May 24, 2017

This does a number of things:

  • Displays coverage output for uncovered code when you run a coverage-* environment
  • Orders tests so that more recent Python and Twisted versions tend to run first.
  • Adds a mypy environment, not yet enabled in the envlist (or Travis).

@wsanchez wsanchez self-assigned this May 24, 2017
@codecov
Copy link

codecov bot commented May 24, 2017

Codecov Report

Merging #182 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #182      +/-   ##
==========================================
- Coverage   95.89%   95.88%   -0.01%     
==========================================
  Files          12       12              
  Lines        1558     1532      -26     
  Branches       86       87       +1     
==========================================
- Hits         1494     1469      -25     
  Misses         52       52              
+ Partials       12       11       -1
Impacted Files Coverage Δ
src/klein/test/py3_test_resource.py 96% <ø> (ø) ⬆️
src/klein/resource.py 91.24% <0%> (-0.07%) ⬇️
src/klein/__init__.py 100% <0%> (ø) ⬆️
src/klein/test/test_resource.py 96.91% <0%> (+0.01%) ⬆️
src/klein/app.py 98.6% <0%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dba85f8...e7b3801. Read the comment docs.

@wsanchez
Copy link
Member Author

OK, ready for review.

@wsanchez
Copy link
Member Author

wsanchez commented Jun 1, 2017

OK this is ready for review

@wsanchez wsanchez removed their assignment Jun 6, 2017
@wsanchez
Copy link
Member Author

wsanchez commented Jun 6, 2017

Gonna make this more bite-sized. Subtasks:

@dpnova
Copy link

dpnova commented Aug 24, 2017

Are you using mypy with klein @wsanchez ? How do you find it if so?

@wsanchez
Copy link
Member Author

#187 is the last part of this, so closing this in favor of that.

@wsanchez wsanchez closed this Nov 14, 2017
@wsanchez
Copy link
Member Author

@dpnova: Yes, I am, and I think it's got some flaws but is way better than not having it. The mypy tox environment just got merged to master, FYI.

@wsanchez wsanchez deleted the tox branch November 14, 2017 00:04
@dpnova
Copy link

dpnova commented Nov 14, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants