Refactored test_build.py #565
Conversation
mdellweg
force-pushed
the
refactor_build_tests
branch
3 times, most recently
from
a7820ac
to
875df57
Compare
| f.write("**Blah blah**") | ||
|
|
||
| result = runner.invoke(command, ["--draft", "--date", "01-01-2001"]) | ||
| @with_project() |
There was a problem hiding this comment.
happy to see the reduction in code indentation/nesting :)
| @@ -157,7 +152,12 @@ def test_in_different_dir_config_option(self, runner): | |||
| self.assertEqual(0, result.exit_code) | |||
| self.assertTrue((project_dir / "NEWS.rst").exists()) | |||
|
|
|||
| @with_isolated_runner | |||
| @with_project( | |||
There was a problem hiding this comment.
this is so much easier to read. thanks a lot!
| """ | ||
| foo 7.8.9 (01-01-2001) | ||
| ====================== | ||
| dedent( |
There was a problem hiding this comment.
just asking. Was this change needed? was the test failing with the old code?
For assertion, I prefer to have as little processing as possible.
But we can also have this code... no problem.
There was a problem hiding this comment.
Not specifically needed. But this way it aligns better with the other tests doing assertions the same way.
There was a problem hiding this comment.
Ok. We can merge this. No problem.
Made use of more generic with_[git_]project decorators. Co-authored-by: Adi Roiban <adiroiban@gmail.com>
mdellweg
force-pushed
the
refactor_build_tests
branch
from
dabcb3e
to
3cddf1d
Compare
for more information, see https://pre-commit.ci
|
It looks good. I don't have time to look into the details... but I think that we are fine. |
Made use of more generic with_[git_]project decorators.
Description
Checklist
src/towncrier/newsfragments/. Describe yourchange and include important information. Your change will be included in the public release notes.
docs/tutorial.rstis still up-to-date.docs/cli.rstreflects those changes.docs/configuration.rstreflects those changes.