Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using deprecated packages in CI #630

Merged
merged 6 commits into from
Jul 31, 2024
Merged

Conversation

hynek
Copy link
Member

@hynek hynek commented Jul 31, 2024

pep517 has been deprecated for a long time and we don't need it anymore, courtesy of importlib.metadata.

I appreciate that it's a bit icky since we cannot test it before actually releasing, and I really don't want to slow down a future release.

pep517 has been deprecated for a long time and we don't need it anymore,
courtesy of importlib.metadata.
@hynek hynek requested a review from a team as a code owner July 31, 2024 06:46
@hynek
Copy link
Member Author

hynek commented Jul 31, 2024

I tried a fake version and looks good!
CleanShot 2024-07-31 at 08 59 58@2x

cf https://github.com/twisted/towncrier/actions/runs/10175573095/job/28143297512

Copy link
Member

@adiroiban adiroiban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup. Looks good.

@hynek hynek merged commit 68a7a3b into trunk Jul 31, 2024
16 checks passed
@hynek hynek deleted the stop-using-ancient-builder branch July 31, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants