Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use scalameta scalafmt plugin #681

Merged
merged 2 commits into from
Sep 24, 2019

Conversation

regadas
Copy link
Collaborator

@regadas regadas commented Sep 17, 2019

As I expected the switch to the official and updated scalafmt introduces a "some" changes. sbt files are also being checked now.

@regadas
Copy link
Collaborator Author

regadas commented Sep 17, 2019

So apparently, I think there's an issue with mima and scala 2.12.10; The issue is visible in this job and the in the previous commit merged to master.

lightbend-labs/mima#387

@johnynek
Copy link
Collaborator

I think we should stay on 2.12.8 or 9 rather than introduce binary incompatibilities.

@regadas
Copy link
Collaborator Author

regadas commented Sep 18, 2019

@johnynek I went through 2.12.{8, 9, 10} and MiMa reports issues in all of them when comparing against the latest version 0.13.5 with 2.12.7. AFAICT it's mostly the DirectMissingMethodProblem which, and if i understood correctly, is related to what @dwijnand mentioned.

Since this is a new thing being reported and previous kinda have the same issue, maybe it's kind of ok to exclude this for now till a new release is out?

@dwijnand
Copy link

I've opened lightbend-labs/mima#388 that describes the problem and how MiMa could be enhanced to handle it universally.

@codecov-io
Copy link

Codecov Report

Merging #681 into develop will increase coverage by 0.15%.
The diff coverage is 77.77%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #681      +/-   ##
===========================================
+ Coverage     89.5%   89.65%   +0.15%     
===========================================
  Files          112      112              
  Lines         8943     8944       +1     
  Branches       314      314              
===========================================
+ Hits          8004     8019      +15     
+ Misses         939      925      -14
Impacted Files Coverage Δ
...re/src/main/scala/com/twitter/algebird/QTree.scala 79.41% <ø> (ø) ⬆️
...la/com/twitter/algebird/monad/StateWithError.scala 42.1% <ø> (ø) ⬆️
...in/scala/com/twitter/algebird/BaseProperties.scala 97.61% <ø> (ø) ⬆️
...src/main/scala/com/twitter/algebird/Preparer.scala 29.03% <ø> (ø) ⬆️
...com/twitter/algebird/GeneratedProductAlgebra.scala 97.43% <ø> (ø) ⬆️
...src/main/scala/com/twitter/algebird/Identity.scala 66.66% <ø> (ø) ⬆️
...witter/algebird/bijection/AlgebirdBijections.scala 0% <ø> (ø) ⬆️
...main/scala/com/twitter/algebird/RightFolded2.scala 94.44% <ø> (ø) ⬆️
...gebird/util/summer/HeavyHittersCachingSummer.scala 86.9% <ø> (ø) ⬆️
.../com/twitter/algebird/util/summer/NullSummer.scala 88.88% <ø> (ø) ⬆️
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e689da...4c2396d. Read the comment docs.

@regadas
Copy link
Collaborator Author

regadas commented Sep 23, 2019

@johnynek rebased with develop

Copy link
Collaborator

@johnynek johnynek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@johnynek johnynek merged commit e74bfdc into twitter:develop Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants