-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use scalameta scalafmt plugin #681
Conversation
So apparently, I think there's an issue with |
I think we should stay on 2.12.8 or 9 rather than introduce binary incompatibilities. |
@johnynek I went through Since this is a new thing being reported and previous kinda have the same issue, maybe it's kind of ok to |
I've opened lightbend-labs/mima#388 that describes the problem and how MiMa could be enhanced to handle it universally. |
78878e7
to
4c2396d
Compare
Codecov Report
@@ Coverage Diff @@
## develop #681 +/- ##
===========================================
+ Coverage 89.5% 89.65% +0.15%
===========================================
Files 112 112
Lines 8943 8944 +1
Branches 314 314
===========================================
+ Hits 8004 8019 +15
+ Misses 939 925 -14
Continue to review full report at Codecov.
|
@johnynek rebased with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
As I expected the switch to the official and updated scalafmt introduces a "some" changes.
sbt
files are also being checked now.