update rubocop

tycooon · Aug 31, 2018 · 8fabe3d · 8fabe3d
1 parent 9308e43
commit 8fabe3d
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 3 deletions.
diff --git a/.rubocop.yml b/.rubocop.yml
@@ -4,3 +4,9 @@ inherit_gem:
 AllCops:
   DisplayCopNames: true
   TargetRubyVersion: 2.5
+
+Naming/UncommunicativeMethodParamName:
+  AllowedNames: ["x", "y", "z"]
+
+RSpec/EmptyLineAfterHook:
+  Enabled: false
diff --git a/Gemfile b/Gemfile
@@ -2,3 +2,5 @@
 
 source "https://rubygems.org"
 gemspec
+
+gem "rubocop-config-umbrellio", github: "umbrellio/code-style"
diff --git a/memery.gemspec b/memery.gemspec
@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-lib = File.expand_path("../lib", __FILE__)
+lib = File.expand_path("lib", __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require "memery/version"
 

diff --git a/spec/memery_spec.rb b/spec/memery_spec.rb
@@ -78,11 +78,11 @@ class << self
 end
 
 RSpec.describe Memery do
+  subject(:a) { A.new }
+
   before { CALLS.clear }
   before { B_CALLS.clear }
 
-  subject(:a) { A.new }
-
   context "methods without args" do
     specify do
       values = [ a.m, a.m_nil, a.m, a.m_nil ]