-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add entry_point & setuptools-git, disable "create_init_files" #371
base: development
Are you sure you want to change the base?
Conversation
PR Review ChecklistDo not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed. Trivial Change
Code
Architecture
|
Hi @dmitrii-ubskii @alexjpwalker Can you take a look at this PR? Thanks! |
Do you mind showing some examples of how/why these changes are to be used please? |
Hi @flyingsilverfin , I think the Regarding the other change, the use case is that we used this rule to assemble one of our internal python library, and then use it in another project. We met some issues during "# path manipulation added by bazelbuild/rules_python to support namespace pkgs. However, since we hardcoded an empty |
Hi, thanks for the contribution! By way of update (and managing expectations), unfortunately we don't currently have the resources to test this code in detail and I don't have an ETA on that. Please continue to depend on your fork of |
+1 for merging this PR into master branch. I am already using this change from PR branch. |
What is the goal of this PR?
This PR is to: