-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Wandalen/wretry.action@v3 with subactions #24
Conversation
…en/wretry.action@v3/pre, and Wandalen/wretry.action@v3/post
Upstream was merged too. :-) |
We need the action to get a new release (under a major version tag/branch as well) with the typings, then we just remove the typings from the catalog and that's all! |
But that's a breaking change. Or if someone uses v1.0.1 with the v1 typings from the catalog and the action adds the typings in v1.0.2, then the 1.0.1 usage will also be broken when removing from the catalog. |
If Wandalen adds a new major version (v2), then you're right, we should keep the typings as we're the only source of typings for your exemplary v1. But if they just update the existing major version tag/branch with the typings, I think we're safe. |
As I said, not if anyone uses a version more concrete than just major:
When you request 1.3, it uses the upstream typings. |
Ok, I see it now. The typings has been in the catalog for 10 hours, I think in this particular case we can assume it's fairly ok to remove, although technically being a breaking change. We could do that if the action owner released the action. The longer the wait is, the more risky it is to remove the typings from the catalog. I'm wondering if we should maybe remove them now to decrease a chance of someone starting relying on them, and ask the action owner to release. The typings are already in the action, so from my perspective the release will happen within several days. WDYT? |
I mainly meant in general. |
Upstream PR: Wandalen/wretry.action#167