Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Wandalen/wretry.action@v3 with subactions #24

Merged
merged 1 commit into from
Aug 18, 2024

Conversation

Vampire
Copy link
Collaborator

@Vampire Vampire commented Aug 18, 2024

…en/wretry.action@v3/pre, and Wandalen/wretry.action@v3/post
@krzema12 krzema12 changed the title Add Wandalen/wretry.action@v3, Wandalen/wretry.action@v3/main, Wandalen/wretry.action@v3/pre, and Wandalen/wretry.action@v3/post Add Wandalen/wretry.action@v3 with subactions Aug 18, 2024
@krzema12 krzema12 merged commit f457f8b into typesafegithub:main Aug 18, 2024
@Vampire Vampire deleted the wretry.action branch August 18, 2024 20:42
@Vampire
Copy link
Collaborator Author

Vampire commented Aug 19, 2024

Upstream was merged too. :-)
Do we need to do something here, for example to not handle updates?

@krzema12
Copy link
Member

krzema12 commented Aug 19, 2024

We need the action to get a new release (under a major version tag/branch as well) with the typings, then we just remove the typings from the catalog and that's all!

@Vampire
Copy link
Collaborator Author

Vampire commented Aug 19, 2024

But that's a breaking change.
If we have typings for v1 and the action adds typings for v2, then if we remove the typing from the catalog all v1 usage is broken.

Or if someone uses v1.0.1 with the v1 typings from the catalog and the action adds the typings in v1.0.2, then the 1.0.1 usage will also be broken when removing from the catalog.

@krzema12
Copy link
Member

If Wandalen adds a new major version (v2), then you're right, we should keep the typings as we're the only source of typings for your exemplary v1. But if they just update the existing major version tag/branch with the typings, I think we're safe.

@Vampire
Copy link
Collaborator Author

Vampire commented Aug 19, 2024

But if they just update the existing major version tag/branch with the typings, I think we're safe.

As I said, not if anyone uses a version more concrete than just major:

?? Requesting tecolicom/actions-use-homebrew-tools@v1.2
  ... from https://raw.githubusercontent.com/tecolicom/actions-use-homebrew-tools/v1.2/action.yml
  ... types from https://raw.githubusercontent.com/tecolicom/actions-use-homebrew-tools/v1.2/action-types.yml
  ... types from https://raw.githubusercontent.com/tecolicom/actions-use-homebrew-tools/v1.2/action-types.yaml
  ... types from https://raw.githubusercontent.com/typesafegithub/github-actions-typing-catalog/main/typings/tecolicom/actions-use-homebrew-tools/v1/action-types.yml
?? Requesting tecolicom/actions-use-homebrew-tools@v1.2
?? Requesting tecolicom/actions-use-homebrew-tools@v1.2
?? Requesting tecolicom/actions-use-homebrew-tools@v1.2
?? Requesting tecolicom/actions-use-homebrew-tools@v1.2
?? Requesting tecolicom/actions-use-homebrew-tools@v1.2

?? Requesting tecolicom/actions-use-homebrew-tools@v1.3
  ... from https://raw.githubusercontent.com/tecolicom/actions-use-homebrew-tools/v1.3/action.yml
  ... types from https://raw.githubusercontent.com/tecolicom/actions-use-homebrew-tools/v1.3/action-types.yml
?? Requesting tecolicom/actions-use-homebrew-tools@v1.3
?? Requesting tecolicom/actions-use-homebrew-tools@v1.3
?? Requesting tecolicom/actions-use-homebrew-tools@v1.3
?? Requesting tecolicom/actions-use-homebrew-tools@v1.3
?? Requesting tecolicom/actions-use-homebrew-tools@v1.3

When you request 1.3, it uses the upstream typings.
When you request 1.2, it uses the catalog v1 typings.

@krzema12
Copy link
Member

Ok, I see it now. The typings has been in the catalog for 10 hours, I think in this particular case we can assume it's fairly ok to remove, although technically being a breaking change. We could do that if the action owner released the action. The longer the wait is, the more risky it is to remove the typings from the catalog. I'm wondering if we should maybe remove them now to decrease a chance of someone starting relying on them, and ask the action owner to release. The typings are already in the action, so from my perspective the release will happen within several days. WDYT?

@Vampire
Copy link
Collaborator Author

Vampire commented Aug 19, 2024

I mainly meant in general.
In this case I'm probably the only one using the 5 recent typings so far, yeah, and I have it not productive yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants