Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update to use Hibernate 5 and Spring JPA; fix topic w/ announc… #304

Merged
merged 1 commit into from
Nov 6, 2023
Merged

chore: update to use Hibernate 5 and Spring JPA; fix topic w/ announc… #304

merged 1 commit into from
Nov 6, 2023

Conversation

groybal
Copy link
Contributor

@groybal groybal commented Sep 22, 2023 •
edited
Loading

…ements export issue

This PR does the following:

  • updates Hibernate version from 3.6 to 5.6 (in prep for Spring 5 upgrade)
  • adds use of Spring Data JPA
  • fixes data export failure issue for topics that have announcements (Exporter.java)

@groybal groybal force-pushed the hibernate-spring-data-jpa branch 2 times, most recently from f20060f to 48b234e Compare September 23, 2023 00:17
@groybal groybal marked this pull request as ready for review September 23, 2023 00:22
@groybal
Copy link
Contributor Author

groybal commented Sep 28, 2023

Per PR review meeting, I have done the following:

  • removed unused property from pom.xml
  • added comment noting why some code in AnnouncementsService is commented out (for use later)
  • tested and verified that hibernate property overrides still works

@bjagg bjagg merged commit 35eeec2 into uPortal-Project:master Nov 6, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@groybal @bjagg