Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix relative links in same physical folder #234

Merged
merged 1 commit into from
Sep 18, 2019
Merged

fix relative links in same physical folder #234

merged 1 commit into from
Sep 18, 2019

Conversation

jckr
Copy link
Contributor

@jckr jckr commented Aug 21, 2019

This is in response to #229.

@jckr
Copy link
Contributor Author

jckr commented Aug 21, 2019

Hi @isaacbrodsky, this addresses #229. I also left a comment on #230 so lmk if that approach works for you
Screen Shot 2019-08-21 at 3 43 02 PM

ibgreen
ibgreen approved these changes Aug 21, 2019
View reviewed changes
Copy link
Collaborator

@ibgreen ibgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd strongly recommend start adding some test case and also start documenting our link rewrite logic in the user docs.

Adding a test case and a few lines of docs in each PR goes a long way to getting this on track.

@jckr
Copy link
Contributor Author

jckr commented Aug 23, 2019

I've started a branch with updated documentation. we definitely need more tests too

@jckr jckr merged commit acb4b83 into master Sep 18, 2019
@xintongxia xintongxia deleted the fix-relative-links branch October 9, 2019 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibgreen ibgreen ibgreen approved these changes

@isaacbrodsky isaacbrodsky Awaiting requested review from isaacbrodsky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jckr @ibgreen