Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dev-tools) babel config overrides nesting #428

Closed

Conversation

chrisgervang
Copy link
Collaborator

For #427

Changes

  • Babel overrides should be nested under overrides
  • The overrides type can be an array or undefined. Babel throws ConfigError: .overrides must be an array, or undefined otherwise.

Copy link
Collaborator

@ibgreen ibgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ConfigError: .overrides must be an array, or undefined otherwise.

My only concern is that I wonder why has this has not been a problem before?
Is this error new in a recent version of babel?

@chrisgervang
Copy link
Collaborator Author

chrisgervang commented Aug 16, 2023

Discussed with @Pessimistress, the api's intention is probably

overrides: {
  // global overrides
  overrides: [{}] // babel's overrides api
}

I'm going to change the docs instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants