Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dev-tools): eslint default config clean up #466

Merged
merged 1 commit into from
May 6, 2024
Merged

Conversation

Pessimistress
Copy link
Collaborator

There are some, but very few, changes in the default behavior, hopefully for good reasons.

  • Upgrade prettier/typescript eslint plugins
  • Remove deprecated rules
  • Remove overrides that are already covered by the base recommended set
  • Limit the number of rules that are turned off - only hide a rule if we truly don't want it. The "disabled-for-convenience" rules such as strict type checks should be explicitly called out in each repo's own eslint config.
  • Document reasons for the overrides
  • Lint error fixes

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8874756570

Details

  • 52 of 53 (98.11%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 88.786%

Changes Missing Coverage Covered Lines Changed/Added Lines %
modules/dev-tools/src/configuration/get-eslint-config.ts 51 52 98.08%
Files with Coverage Reduction New Missed Lines %
modules/dev-tools/src/utils/utils.ts 2 60.0%
Totals Coverage Status
Change from base Build 8869315834: -0.2%
Covered Lines: 1043
Relevant Lines: 1166

💛 - Coveralls

@Pessimistress Pessimistress merged commit 1f78a10 into master May 6, 2024
4 checks passed
@Pessimistress Pessimistress deleted the x/eslint branch May 6, 2024 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants