Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conda-based test #514

Closed
wants to merge 4 commits into from
Closed

Add conda-based test #514

wants to merge 4 commits into from

Conversation

lang-m
Copy link
Member

@lang-m lang-m commented Nov 25, 2023

No description provided.

Copy link
Contributor

PR Analysis

  • 🎯 Main theme: Adding a new GitHub Actions workflow for testing with conda
  • 📝 PR summary: This PR introduces a new GitHub Actions workflow that sets up a conda environment and runs unit tests, documentation tests, and Jupyter notebook tests on Ubuntu, MacOS, and Windows operating systems for Python versions 3.8 and 3.10.
  • 📌 Type of PR: Tests
  • 🧪 Relevant tests added: Yes
  • ⏱️ Estimated effort to review [1-5]: 2, because the PR is straightforward and doesn't involve complex logic. It only adds a new GitHub Actions workflow.
  • 🔒 Security concerns: No security concerns found

PR Feedback

  • 💡 General suggestions: The PR is well-structured and follows best practices for setting up a GitHub Actions workflow. It would be beneficial to add error handling or retries for network-dependent steps to make the workflow more robust.

  • 🤖 Code feedback:

    • relevant file: .github/workflows/conda.yml
      suggestion: Consider adding a 'cache' step to speed up the workflow by caching dependencies that don't change often. [medium]
      relevant line: - name: Install package

How to use

Instructions

To invoke the PR-Agent, add a comment using one of the following commands:
/review: Request a review of your Pull Request.
/describe: Update the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback.
/ask <QUESTION>: Ask a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.
/add_docs: Generate docstring for new components introduced in the PR.
/generate_labels: Generate labels for the PR based on the PR's contents.
see the tools guide for more details.

To edit any configuration parameter from the configuration.toml, add --config_path=new_value.
For example: /review --pr_reviewer.extra_instructions="focus on the file: ..."
To list the possible configuration parameters, add a /config comment.

@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (30bf3c7) 93.49% compared to head (14323ce) 93.49%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #514   +/-   ##
=======================================
  Coverage   93.49%   93.49%           
=======================================
  Files          28       28           
  Lines        3027     3027           
=======================================
  Hits         2830     2830           
  Misses        197      197           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lang-m
Copy link
Member Author

lang-m commented Dec 4, 2023

Fixed in conda-forge/discretisedfield-feedstock#37 (mistake in conda packaging)

@lang-m lang-m closed this Dec 4, 2023
@lang-m lang-m deleted the debug-conda-windows-problem branch December 4, 2023 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants