-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sfc_climo_gen - use scale parameter to read scaled datasets #958
base: develop
Are you sure you want to change the base?
Conversation
Merge remote-tracking branch 'upstream/develop' into develop
@sanatcumar - there should be a list of tests in the description section (automatically added via by this file: https://github.com/ufs-community/UFS_UTILS/blob/develop/.github/PULL_REQUEST_TEMPLATE) I will add them manually. |
@sanatcumar - what is the status of this PR? |
Hi George , I was waiting on using this new data sets for some test runs before I do this. This also involves adding a new data set to the fix directories. Could you refresh my memory on whom to contact or to raise a new dependency issue ? I see you have added from template. Thanks. I will do some quick checks and request a review soon. Cheers and thanks again |
If you want new 'fixed' data hosted to the official baselines, make your request here (fixed file update): https://github.com/NOAA-EMC/global-workflow/issues/new/choose |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your branch looks out of date. Merge the latest updates from 'develop'.
Also, I see a branch called 'use_scale' in the authoritative fork. What is that? All branches should be in user forks.
Hi George, Just synced to the latest develop and also deleted the branch in the authoritative fork. Thanks for pointing it out . |
@sanatcumar - did you perform any of the tests under "TEST CONDUCTED". If you don't have access to a machine listed, let me know and I can run the tests for you. |
Hi @GeorgeGayno-NOAA , thanks, |
@sanatcumar - what is the status of this PR? |
Hi George, |
I would need to see your test script. How big is this new LAI data? |
Hi @GeorgeGayno-NOAA, the file size is about 10 Gigs . If you can see the log file at /home/skumar/UFS_UTILS/driver_scripts/log.fv3_grid_driver "
I used Hope you can help me resolve this. |
You can try increasing the nodes - try 8 nodes and 12 tasks per node. The LAI uses conservative interpolation, which is likely very expensive. If increasing the nodes does not work, you may have to upscale LAI dataset to 0.03 or 0.05-degree as we have done with the soil and vegetation type datasets. Or you can try a different interpolation method. Since we are running into these memory issues more frequently, perhaps we should replace |
DESCRIPTION OF CHANGES:
Update
sfc_climo_gen
to use optional scaling parameter to read surface fields when used.TESTS CONDUCTED:
If there are changes to the build or source code, the tests below must be conducted. Contact a repository manager if you need assistance.
Describe any additional tests performed.
DEPENDENCIES:
Add any links to pending PRs that are required prior to merging this PR. For example:
ufs-community/UFS_UTILS/pull/<pr_number>
DOCUMENTATION:
If this PR is contributing new capabilities that need to be documented, please also include updates to the RST files in the docs/source directory as supporting material.
ISSUE:
Fixes #957.