-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port to Orion Rocky 9 #966
Port to Orion Rocky 9 #966
Conversation
driver script for Rocky 9 stack. Fixes ufs-community#963.
for Rocky 9. Fixes ufs-community#963.
@DeniseWorthen - the |
I compared your runs against the hercules baseline, since for UWM the baselines on orion/R9 can reproduce the hercules/R9. Compared this way, the cpld_gridgen appears to be b4b, but the ocnice_prep has very small differences, but only in the downscaled velocity fields. The differences I see in your Orion/R9 baselines are very small and along w/ the comparison above, I think they're acceptable/expected with the OS upgrade. Thanks. |
Great. Thanks for checking. |
The regression tests were run on Orion using 3923373. The results: Some
Some
All
All
The
Some
The
The
|
The
|
Denise checked the |
@KateFriedman-NOAA and @DavidHuber-NOAA - could someone please test in the workflow? |
@GeorgeGayno-NOAA The global workflow has not been ported to Orion-rocky9 yet. This may still be a couple of weeks off. I'm happy to test when it is ready and I'm OK with opening another issue/PR if issues are encountered at that time. So if you would like to merge now, the G-W team is fine with that. Tagging @aerorahul for awareness. |
Ok. I don't have a problem waiting. But if a UFS_UTILS user must have access to Orion, I will have to merge early. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks fine to merge.
Just a note for other reviewers;grib-util
should be grib_util
if wcoss2 names are to be consistent
DESCRIPTION OF CHANGES:
Orion was recently upgraded to Rocky 9.
machine_setup.sh
script, which did not recognize Orion after the upgrade.TESTS CONDUCTED:
Compile branch on all Tier 1 machines using Intel. Done using 9199f4a.
Run unit tests on Orion. All passed using 3923373.
Run relevant consistency tests on Orion. Done using 3923373. Some passed. Some failed, but the differences are small and consistent with a change in OS. See comments below for more details:
Port to Orion Rocky 9 #966 (comment)
Port to Orion Rocky 9 #966 (comment)
Port to Orion Rocky 9 #966 (comment)
DEPENDENCIES:
NOAA-EMC/global-workflow#2694
DOCUMENTATION:
N/A
ISSUE:
Fixes #963.