Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes for Jet #981

Merged

Conversation

GeorgeGayno-NOAA
Copy link
Collaborator

@GeorgeGayno-NOAA GeorgeGayno-NOAA commented Sep 10, 2024

DESCRIPTION OF CHANGES:

Minor updates for Jet.

TESTS CONDUCTED:

If there are changes to the build or source code, the tests below must be conducted. Contact a repository manager if you need assistance.

  • Compile branch on Jet using Intel. Done using 36a905f.
  • Run relevant consistency tests locally on Jet. Because of very slow turn-around times on Jet, a subset of each regression test was run using the 'debug' queue. All tests passed. Used 36a905f.

Describe any additional tests performed (using 36a905f)

The gdas_init utility was run for a 2021/03/07/00 test case to ensure that the set_fixed_files.sh script pointed to the correct input orography directory. The test passed.

DEPENDENCIES:

None.

DOCUMENTATION:

N/A

ISSUE:

Fixes #977.

@GeorgeGayno-NOAA GeorgeGayno-NOAA changed the title Bugfix/jet lfs5 Bug fixes for Jet Sep 11, 2024
@GeorgeGayno-NOAA GeorgeGayno-NOAA marked this pull request as ready for review September 11, 2024 13:51
@GeorgeGayno-NOAA
Copy link
Collaborator Author

@KateFriedman-NOAA - thanks for your help.

Copy link
Collaborator

@KateFriedman-NOAA KateFriedman-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @GeorgeGayno-NOAA !

@KateFriedman-NOAA
Copy link
Collaborator

FYI @InnocentSouopgui-NOAA , you'll want the updated hash for Jet after this goes in.

@InnocentSouopgui-NOAA
Copy link
Contributor

Sure I will do that.

@GeorgeGayno-NOAA GeorgeGayno-NOAA merged commit a3237fb into ufs-community:develop Sep 11, 2024
4 checks passed
@GeorgeGayno-NOAA GeorgeGayno-NOAA deleted the bugfix/jet_lfs5 branch September 25, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spack-stack moved from /lfs4 to /contrib on Jet
3 participants