React 18 compatability for react hybrid library #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @christopherthielen, do you still maintain this package. I just wanted to bump this PR. Without these changes the React applications run under React 17 and we can't gain from the improvements in React 18. I would help to make this PR working as I see there were some issues with the checks, I'm just unsure what the issues are. |
|
@todorpr what did you end up doing? I'm thinking of forking it. what were the problems you saw with this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the react-hybrid library to be compatible with react version 18+. This will use the new
createRootrendering API, so you can opt into the newly added features of React 18. This is a (breaking change). I know that there was another pull request out in the wild performing this exact same change. I'm just hoping that this might grab someone's attention.