Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct reference table event logging #2426

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nboyse
Copy link
Contributor

@nboyse nboyse commented Feb 17, 2023

Description of change

Two events are logged when data preview screen loads (“Reference dataset view” which is incorrect and “Reference dataset download” which is also incorrect). This is a PR to ensure that an event is only logged once and the download event is only logged once a user has executed a download.

Checklist

  • Have tests been added to cover any changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant