feature/DT-1803-grant-access-to-dataset #2993
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chopkinsmade
force-pushed
the
feature/DT-1803-grant-access-to-dataset
branch
2 times, most recently
from
8e4b729
to
2f85c3b
Compare
chopkinsmade
force-pushed
the
feature/DT-1803-grant-access-to-dataset
branch
from
2f85c3b
to
2dea0ac
Compare
CaitBarnard
approved these changes
Feb 7, 2024
chopkinsmade
commented
Feb 26, 2024
| @@ -1576,6 +1576,10 @@ def remove_authorised_editor(request, pk, user_id): | |||
| user = get_user_model().objects.get(id=user_id) | |||
|
|
|||
| dataset.data_catalogue_editors.remove(user) | |||
| if dataset.request_approvers and user.email in dataset.request_approvers: | |||
There was a problem hiding this comment.
Blocking until the SSO issue is resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
When an email address is added to the request approvers field, if there is a matching user with that email also add them to the catalogue editors field.
When a catalogue editor is removed using the template form, also remove them from the request approvers field
Checklist