Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: group public/open datasets into fewer roles #3162

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

feat: group public/open datasets into fewer roles #3162

wants to merge 2 commits into from

Conversation

michalc
Copy link
Member

@michalc michalc commented Apr 18, 2024

Description of change

Checklist

  • Have tests been added to cover any changes?
  • Have E2E tests been added to cover any React changes?
  • Have Accessibility tests been added to cover any React changes?

@michalc
refactor: make published available to new_private_database_credentials
3faa176 
This makes the published status of datasets available to
new_private_database_credentials.

This is a stepping stone to grouping the open datasets into a roles to
try to address connection performance problems. To do this, we need
user_access_type which is already there, but also the published status of
datasets - because superusers are allowed to access unpublished datasets. So we
are probably going to have to have 2 roles: one for published open datasets
that everyone has access to, and one for the unpublished ones that only
superusers have access to.
@michalc michalc changed the title refactor: make published available to new_private_database_credentials feat: group publish/open datasets into fewer roles Apr 18, 2024
@michalc
refactor: make a suggested role for each table available to get_new_c…
3faf84f 
…redentials

This makes a suggested role for each table that a user has access to available
to get_new_credentials. This means that in later commits get_new_credentials
can group tables with the same suggested role, which should then reduce the
number of roles each user has, and hopefully make connecting faster.
@michalc michalc changed the title feat: group publish/open datasets into fewer roles feat: group public/open datasets into fewer roles Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@michalc