Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update isEditable implementation #99

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ap0nia
Copy link

@ap0nia ap0nia commented Oct 14, 2024

Summary

Improve the utility of the isEditable state stored in context. It is writable, and both subscribes to the editor's editable state, as well as writes to it when it is set.

Next Steps

Alternatively, maybe no setIsEditable function needs to be made at all; it can be done in the same function as setEditor since that already receives the editor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant