Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: omit dts errors that not in the built files #711

Merged
merged 4 commits into from
Sep 12, 2023

Conversation

PeachScript
Copy link
Member

@PeachScript PeachScript commented Sep 12, 2023

d.ts 生成的时候,忽略不在 bundless 文件列表中的类型错误,比如 demosconfig 之类的

动机:father 仅抛出影响产物的类型错误,项目全量的类型错误仍然是 tsc 的职责;另外由于 father 4.3.2 和 4.3.3 修复了部分类型检查错误不抛出的问题,如果 father 扩大类型检查的职责,则会增加影响存量项目构建的概率

Close #710

@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (853de58) 94.32% compared to head (259da43) 94.33%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #711   +/-   ##
=======================================
  Coverage   94.32%   94.33%           
=======================================
  Files          54       54           
  Lines        1534     1535    +1     
  Branches      364      365    +1     
=======================================
+ Hits         1447     1448    +1     
  Misses         87       87           
Files Changed Coverage Δ
src/builder/bundless/dts/index.ts 98.57% <100.00%> (+0.02%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PeachScript PeachScript merged commit 3d6855e into master Sep 12, 2023
9 checks passed
@delete-merged-branch delete-merged-branch bot deleted the hotfix/omit-unexpected-dts-error branch September 12, 2023 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Generate declaration files fail in 4.3.2 and 4.3.3
1 participant