productReviews will throw an error if you fetch any review for a deleted product

[macrozone]

Describe the bug

see this comment #379 (comment)

unchained wrongly sets ProductReview.product to be non-nullable but will return null if the product is deleted (no matter if it got deleted from the db or just marked as deletd.

ProductReview.product should be nullable.

To Reproduce

1. create a review for a product
2. delete that product
3. fetch productReviews via graphql

Expected behavior

ProductReview.product should be nullable.

[macrozone]

by the way, modern grapqhl libraries can prevent misstakes like that. e.g. https://pothos-graphql.dev/ has a really strong type support. If you use strict mode it would complain that your productService (or collection) can return null and would not allow that this result will be used in a non-nullable resolver

[pozylon]

the problem was that the product field did not return deleted products, this is wrong, reviews of deleted products should still return the deleted product. fixed in newest beta.