Skip to content

chore: json encoder cleanup #65

chore: json encoder cleanup

chore: json encoder cleanup #65

Triggered via pull request September 28, 2024 23:53
Status Failure
Total duration 47s
Artifacts

test.yaml

on: pull_request
Matrix: tests
Fit to window
Zoom out
Zoom in

Annotations

9 errors and 18 warnings
golangci: render_json_test.go#L27
Error return value of `e.w.Write` is not checked (errcheck)
golangci: engine.go#L14
interface method Render must have named param for type io.Writer (inamedparam)
golangci: genericbufferpool.go#L8
interface method Put must have all named params (inamedparam)
golangci: render_json_test.go#L22
NewEncoder returns interface (github.com/unrolled/render.JSONEncoder) (ireturn)
golangci: render_json_test.go#L28
return with no blank line before (nlreturn)
golangci: helpers.go#L12
fmt.Errorf can be replaced with errors.New (perfsprint)
golangci: helpers.go#L15
fmt.Errorf can be replaced with errors.New (perfsprint)
golangci: render.go#L263
if statements should only be cuddled with assignments (wsl)
golangci
issues found
golangci
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, golangci/golangci-lint-action@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
golangci
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v2, golangci/golangci-lint-action@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
golangci
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
golangci
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
golangci: helpers_test.go#L17
unused-parameter: parameter 'r' seems to be unused, consider removing or renaming it as _ (revive)
golangci: helpers_test.go#L41
unused-parameter: parameter 'r' seems to be unused, consider removing or renaming it as _ (revive)
golangci: helpers_test.go#L64
unused-parameter: parameter 'r' seems to be unused, consider removing or renaming it as _ (revive)
golangci: render_json_test.go#L26
unused-parameter: parameter 'v' seems to be unused, consider removing or renaming it as _ (revive)
golangci: render_json_test.go#L31
unused-parameter: parameter 'on' seems to be unused, consider removing or renaming it as _ (revive)
golangci: render_json_test.go#L33
unused-parameter: parameter 'prefix' seems to be unused, consider removing or renaming it as _ (revive)
tests (1.18.x, ubuntu-latest)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/setup-go@v2, actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
tests (1.18.x, ubuntu-latest)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-go@v2, actions/checkout@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
tests (1.19.x, ubuntu-latest)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/setup-go@v2, actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
tests (1.19.x, ubuntu-latest)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-go@v2, actions/checkout@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
tests (1.20.x, ubuntu-latest)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/setup-go@v2, actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
tests (1.20.x, ubuntu-latest)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-go@v2, actions/checkout@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
tests (1.21.x, ubuntu-latest)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/setup-go@v2, actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
tests (1.21.x, ubuntu-latest)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-go@v2, actions/checkout@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/