fix: handle network errors in pi API client - #3058
Open
abhijeet117 wants to merge 2 commits into
Open
Conversation
The pi package API functions called fetch without try-catch, causing unhandled rejections on network failures. Wrapped both functions in try-catch to return user-friendly error messages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The pi package API functions called fetch without try-catch, so network failures (DNS errors, timeouts, connection resets) surfaced as unhandled exceptions and crashed the tool call instead of returning a readable error. Wrapped searchLibraries and fetchLibraryContext in try-catch, matching the MCP package implementation, so failures return user-friendly error strings.
Testing
Reproduced by mocking fetch to reject with a network error; both functions threw before the fix and now return error messages instead. Added packages/pi/tests/api.test.ts covering network failures, non-ok statuses, empty bodies, and successful responses. All 11 pi package tests pass.
Checklist