address review comments

upstash · Jul 10, 2023 · 5474d72 · 5474d72
1 parent 6f2b708
commit 5474d72
Show file tree

Hide file tree

Showing 6 changed files with 19 additions and 25 deletions.
diff --git a/README.md b/README.md
@@ -113,7 +113,7 @@ You also have the option to try and wait for a request to pass in the given time
 
 It is very similar to the `limit` method and takes an identifier and returns the same 
 response. However if the current limit has already been exceeded, it will automatically 
-wait until the next window starts and will try again. Setting the timeout parameter (in seconbds) will cause the method to block a finite amount of time.
+wait until the next window starts and will try again. Setting the timeout parameter (in seconds) will cause the method to block a finite amount of time.
 
 ```python
 from upstash_ratelimit import Ratelimit, SlidingWindow

diff --git a/poetry.lock b/poetry.lock
diff --git a/pyproject.toml b/pyproject.toml
@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "upstash-ratelimit"
-version = "0.4.2"
+version = "0.5.0"
 description = "Serverless ratelimiting package from Upstash"
 authors = ["Upstash <support@upstash.com>", "Zgîmbău Tudor <tudor.zgimbau@gmail.com>"]
 maintainers = ["Upstash <support@upstash.com>"]
@@ -26,7 +26,7 @@ packages = [{include = "upstash_ratelimit"}]
 
 [tool.poetry.dependencies]
 python = "^3.8"
-upstash-redis = "^0.14.5"
+upstash-redis = "^0.15.0"
 
 [tool.poetry.group.dev.dependencies]
 pytest = "^7.3.0"

diff --git a/tests/conftest.py b/tests/conftest.py
@@ -12,8 +12,7 @@ def redis():
 
 @pytest_asyncio.fixture
 async def async_redis():
-    redis = AsyncRedis.from_env()
-    async with redis:
+    async with AsyncRedis.from_env() as redis:
         yield redis
 
 

diff --git a/upstash_ratelimit/__init__.py b/upstash_ratelimit/__init__.py
@@ -1,4 +1,4 @@
-__version__ = "0.4.2"
+__version__ = "0.5.0"
 
 from upstash_ratelimit.limiter import FixedWindow, Response, SlidingWindow, TokenBucket
 from upstash_ratelimit.ratelimit import Ratelimit

diff --git a/upstash_ratelimit/limiter.py b/upstash_ratelimit/limiter.py
@@ -101,10 +101,7 @@ async def _with_at_most_one_request_async(
         return response
 
     command: Callable = getattr(redis, command_name)
-    # TODO: Remove async with once we release the new version of the client
-    async with redis:
-        command_response = await command(*command_args)
-
+    command_response = await command(*command_args)
     response = generator.send(command_response)
     return response