Fix modal bg (#3171)

* Fix modal bg * Fix button padding
urbanairship · Jul 30, 2024 · c6603d8 · c6603d8
1 parent 6a35cde
commit c6603d8
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 15 deletions.
diff --git a/Airship/AirshipCore/Source/LabelButton.swift b/Airship/AirshipCore/Source/LabelButton.swift
@@ -24,6 +24,7 @@ struct LabelButton : View {
             actions: self.model.actions
         ) {
             Label(model: self.model.label, constraints: constraints)
+                .padding(self.model.border?.strokeWidth ?? 0)
                 .constraints(constraints, fixedSize: true)
                 .applyIf(self.constraints.height == nil) { view in
                     view.padding([.bottom, .top], 12)

diff --git a/Airship/AirshipCore/Source/ModalView.swift b/Airship/AirshipCore/Source/ModalView.swift
@@ -156,25 +156,34 @@ struct ModalView: View {
 
     @ViewBuilder
     private func modalBackground(_ placement: ModalPlacement) -> some View {
-        if placement.isFullScreen() && placement.ignoreSafeArea != true {
-            Rectangle()
-                .foregroundColor(statusBarShimColor())
-                .edgesIgnoringSafeArea(.all)
-
-        } else {
-            Rectangle()
-                .foreground(placement.shade)
-                .edgesIgnoringSafeArea(.all)
-                .applyIf(self.presentation.dismissOnTouchOutside == true) {
-                    view in
-                    // Add tap gesture outside of view to dismiss
-                    view.addTapGesture {
-                        self.thomasEnvironment.dismiss()
+        GeometryReader { reader in
+            VStack(spacing: 0) {
+                if placement.isFullscreen, placement.ignoreSafeArea != true {
+                    statusBarShimColor()
+                        .frame(height: reader.safeAreaInsets.top)
+                }
+
+                Rectangle()
+                    .foreground(placement.shade)
+                    .edgesIgnoringSafeArea(.all)
+                    .applyIf(self.presentation.dismissOnTouchOutside == true) {
+                        view in
+                        // Add tap gesture outside of view to dismiss
+                        view.addTapGesture {
+                            self.thomasEnvironment.dismiss()
+                        }
                     }
+
+                if placement.isFullscreen, placement.ignoreSafeArea != true {
+                    statusBarShimColor()
+                        .frame(height: reader.safeAreaInsets.bottom)
                 }
+            }
+            .edgesIgnoringSafeArea(.all)
         }
     }
 
+
     private func resolvePlacement(
         orientation: Orientation,
         windowSize: WindowSize
@@ -242,7 +251,7 @@ struct ModalView: View {
 
 
 extension ModalPlacement {
-    fileprivate func isFullScreen() -> Bool {
+    fileprivate var isFullscreen: Bool {
         if let horiztonalMargins = self.margin?.horiztonalMargins, horiztonalMargins > 0 {
             return false
         }