Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getOffset function to render elements in iframe offset from the p… #1934

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Coder2002-MSAdithya
Copy link

This fix does NOT affect any other parts of the project and is also backward compatible. This idea was originally given by arjshiv(Arjun Kannan) back in 2015

@vercel
Copy link

vercel bot commented Jun 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
intro-js ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 13, 2023 6:19am

left: 0
}

if((element) && (element.ownerDocument !== window.document))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add e2e tests for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants