-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using only-parameters for surveys #1378
base: development
Are you sure you want to change the base?
Conversation
this.getPostAllowedTypes(); | ||
private getSurveys(): void { | ||
this.surveysService | ||
.getSurveys('', { only: 'name,color,everyone_can_create,can_create' }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe the string literal should be in a constant file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and works nicely. I left a little suggestion but otherwise 👍
@ushahidlee And done! Moved the strings to the apiHelper, I think that makes sense since they will be the same in the mobile-app probably... |
This PR changes to use only-parameters for surveys for:
To test: Smoke-test on above functionalities, they should work as before 😬