Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/module and meta constraints namespace prefixes #686

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

david-waltermire
Copy link
Collaborator

@david-waltermire david-waltermire commented Jul 11, 2024

Committer Notes

This PR adds support for prefix to namespace bindings for use in Metapath for supporting multiple models and Metapath types and functions with colliding names.

This PR will:

  • Allow qualified names to be used that reference a namespace URI by prefix. This is needed to 1) support the composition of models that have naming conflicts, and 2) support data types, functions and variables declared in user defined namespaces.
  • Provide a path for implementations to support inline Metapath functions to be declared and used in user defined namespaces.

This PR builds on PR #659 and #570, which should be merged first.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all website](https://pages.nist.gov/metaschema) and readme documentation affected by the changes you made? Changes to the website can be made in the website/content directory of your branch.

…check.sch as Metaschema external module constraints.
@david-waltermire david-waltermire mentioned this pull request Jul 22, 2024
8 tasks
@david-waltermire david-waltermire marked this pull request as ready for review July 22, 2024 17:01
…dules and external constraints for supporting multiple models and Metapath types and functions with colliding names that are in different namespaces. This better aligns Metapath with the XPath 3.1 specification.
@david-waltermire david-waltermire force-pushed the feature/module-and-meta-constraints-namespace-prefixes branch from d089dde to 5ec4066 Compare July 24, 2024 12:51
@david-waltermire
Copy link
Collaborator Author

This should be merged using "rebase and merge" to avoid merge conflicts in downstreams.

@iMichaela
Copy link
Collaborator

iMichaela commented Jul 25, 2024

This should be merged using "rebase and merge" to avoid merge conflicts in downstreams.

Thank you, @david-waltermire . Do you mind including in this PR the fix for the README.md - the link [✖] https://www.nist.gov/people/david-waltermire points to your page that does not exist anymore and direct it to a valid page you have? In the meantime I'll work on permissions. I am doing my best to expedite it.

@david-waltermire
Copy link
Collaborator Author

david-waltermire commented Aug 21, 2024

I am not sure what the README should say. Feel free to update it. I can rebase this PR once the underlying repo issues are fixed.

@iMichaela
Copy link
Collaborator

@david-waltermire -- please note the PR #659 this PR depends on needs to be rebased first. Also, this PR will need to be rebased to address the conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants