Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for LB with DNS hostname only #230

Merged
merged 4 commits into from
Jul 17, 2023
Merged

Add support for LB with DNS hostname only #230

merged 4 commits into from
Jul 17, 2023

Conversation

fl42
Copy link
Contributor

@fl42 fl42 commented Jul 11, 2023 •
edited
Loading

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

AWS Load Balancer (NLB) now uses DNS-based hostname. This PR adds support to extract hostname from Kubernetes Service.

@fl42 fl42 requested a review from utkuozdemir as a code owner July 11, 2023 08:37
@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2023 •
edited
Loading

Codecov Report

Merging #230 (65f7354) into master (7066a84) will decrease coverage by 0.14%.
The diff coverage is 40.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master     #230      +/-   ##
==========================================
- Coverage   71.57%   71.43%   -0.14%     
==========================================
  Files          24       24              
  Lines        1780     1782       +2     
==========================================
- Hits         1274     1273       -1     
- Misses        406      407       +1     
- Partials      100      102       +2
Impacted Files Coverage Δ
internal/k8s/service.go 70.00% <40.00%> (-6.32%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@utkuozdemir
Copy link
Owner

Thanks for the PR. Looks good to me. Can you please fix the linter errors? You can use task fmt and task lint for that (you'll need this).

@fl42
Copy link
Contributor Author

fl42 commented Jul 16, 2023

Thanks, fixed 👍

utkuozdemir
utkuozdemir reviewed Jul 17, 2023
View reviewed changes
internal/k8s/service.go Outdated
@@ -59,7 +59,12 @@ func GetServiceAddress(
}

if len(res.Status.LoadBalancer.Ingress) > 0 {
result = res.Status.LoadBalancer.Ingress[0].IP

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove this empty line? Linter is still complaining about it:

Error: unnecessary leading newline (whitespace)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@fl42
Copy link
Contributor Author

fl42 commented Jul 17, 2023

Sorry, I did the quick fix using online IDE ;)

@utkuozdemir utkuozdemir merged commit e9db021 into utkuozdemir:master Jul 17, 2023
2 checks passed
@utkuozdemir
Copy link
Owner

Thanks for the contribution :)

@qjoly qjoly mentioned this pull request Jul 18, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@utkuozdemir utkuozdemir utkuozdemir left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fl42 @codecov-commenter @utkuozdemir