Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Betaflight parameter versioning #82

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kohlerj
Copy link
Contributor

@kohlerj kohlerj commented Oct 23, 2018

No description provided.

@kohlerj kohlerj changed the title Create lumenier_f4_aio_betaflight-v3.2.5_rpg_race_quad.txt Betaflight parameter versioning Oct 23, 2018
Copy link
Contributor

@mfaessle mfaessle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to only use underscores in the file names

Furthermore, please also add the version to the file names of the remaining two parameter files. Or even better, add the corresponding files for the new betaflight version as well.

mode_color 7 0 3

# aux
aux 0 0 0 1775 2100
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these aux channel settings different from version 3.1.7? They must correspond to the channel mapping set in the sbus bridge https://github.com/uzh-rpg/rpg_quadrotor_control/blob/master/bridges/sbus_bridge/include/sbus_bridge/channel_mapping.h

set min_command = 1000
set dshot_idle_value = 450
set use_unsynced_pwm = OFF
set motor_pwm_protocol = DSHOT1200
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe make a comment that this requires one of the new 32 bit ESCs. In general ESC compatibility has to be checked (since we are giving a standard hardware setup on the wiki)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright I will changed it to DSHOT300, most people have at least that right now

# rateprofile
rateprofile 0

set rc_rate = 213
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these values different from version 3.1.7? These rate values must correspond to what is set in the sbus bridge parameters! -> e.g.

set gyro_sync_denom = 1
set gyro_lowpass_type = PT1
set gyro_lowpass_hz = 90
set gyro_notch1_hz = 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These filter parameters were tuned for out platform, if there are problems with vibrations I would recommend doing this again or doing it anyway to avoid such problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants