Skip to content

fix: exclude credential secret from Azure KbsConfig #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
butler54 merged 1 commit into from
Aug 31, 2026
Merged

fix: exclude credential secret from Azure KbsConfig #138

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions overrides/values-trustee-azure.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,3 +43,22 @@ kbs:
abiMinor: "31"
singleSocket: "false"
smtAllowed: "true"

# trustee-chart's default kbs.extraSecrets (["credential"]) is unconditionally
# added to KbsConfig.spec.kbsSecretResources, but the ACM ConfigurationPolicy
# that creates that Secret (pull-secret-credential-policy.yaml) is skipped on
# Azure -- peer-pod CDH doesn't fetch registry credentials from KBS there.
# Without this override, KbsConfig lists a Secret ("credential") that never
# gets created, and the kbsconfig-controller fails to deploy KBS with:
# Error in creating/updating KBS deployment: Secret "credential" not found
#
# Confirmed on a live Azure cluster that image pulls already work via
# sandboxed-policies-chart's pull-secret-distribution mechanism
# (per-namespace 'pull-secret' Secret + default ServiceAccount
# imagePullSecrets patch) -- the KBS 'credential' resource is genuinely
# unnecessary on Azure, not just unused.
#
# Fixed upstream in trustee-chart -- see validatedpatterns/trustee-chart#42.
# This override can be dropped once coco-pattern picks up a trustee
# chartVersion that includes that fix (>= 0.10.1, pending release).
extraSecrets: []
Loading