refactor: Use mobilestack references in android builds #6039
Conversation
| @@ -39,8 +39,8 @@ jobs: | |||
| with: | |||
| secrets: |- | |||
| ANDROID_RELEASE_KEYSTORE:projects/1027349420744/secrets/ANDROID_RELEASE_KEYSTORE | |||
| CELO_RELEASE_KEY_PASSWORD:projects/1027349420744/secrets/CELO_RELEASE_KEY_PASSWORD | |||
| CELO_RELEASE_STORE_PASSWORD:projects/1027349420744/secrets/CELO_RELEASE_STORE_PASSWORD | |||
| MOBILESTACK_RELEASE_KEY_PASSWORD:projects/1027349420744/secrets/MOBILESTACK_RELEASE_KEY_PASSWORD | |||
There was a problem hiding this comment.
I've ported over these secrets in GCP
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6039 +/- ##
==========================================
- Coverage 88.74% 88.74% -0.01%
==========================================
Files 727 727
Lines 30785 30785
Branches 5623 5319 -304
==========================================
- Hits 27321 27320 -1
- Misses 3265 3421 +156
+ Partials 199 44 -155 see 67 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
.github/workflows/e2e-android.yml
Outdated
| @@ -50,6 +50,9 @@ jobs: | |||
| yes | sdkmanager "platform-tools" "platforms;android-${{ inputs.android-api-level }}" | |||
| set -o pipefail | |||
|
|
|||
| # Install Ninja | |||
There was a problem hiding this comment.
See here; not sure why this is now needed, though I have to imagine it's related to the rest of the changes in this PR
|
This seems to fail on the nightly release that I tested due to the build looking for celo-release-key.keystore, despite having removed all apparent references of it from the repo... not sure why this is happening. |
…allet into jophish/android-mobilestack
jophish
changed the title
kathaypacific
dismissed
their stale review
Oh wait, I just saw your comment about the release not working with these changes 🙈
|
The nightly release test passed! https://valora-app.slack.com/archives/C02D08P412Q/p1727385960907899 |
android/gradle.properties
Outdated
| # Note that the key alias lacks Mobile Stack naming, since updating this would | ||
| # require regenerating the keystore. | ||
| MOBILESTACK_RELEASE_STORE_FILE=mobilestack-release-key.keystore | ||
| MOBILESTACK_RELEASE_KEY_ALIAS=celo-key-alias |
There was a problem hiding this comment.
I think we can update the keystore. Also an opportunity to use the same password for the store and the key inside.
There was a problem hiding this comment.
@jeanregisser What's the typical process for this? I assume we want to re-use our existing upload key; I can't seem to find an option in Android Studio (which is what I've used in the past for creating brand new upload keys/keystores) to create a new keystore from an existing key.
There was a problem hiding this comment.
Hey, this can be done using the keytool cli:
- Renaming the alias: https://stackoverflow.com/a/5707518/158525
- Changing the passwords: https://stackoverflow.com/a/56382758/158525
android/app/src/androidTest/java/xyz/mobilestack/mobile/DetoxTest.java
Outdated
Show resolved
Hide resolved
Description
Makes the Android builds more brand agnostic.
Test plan
Related issues
Backwards compatibility
Network scalability
If a new NetworkId and/or Network are added in the future, the changes in this PR will: