feat(earn): Add Claiming Reward line item on enter amount screen #6169
+76
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/earn/EarnDepositBottomSheet.tsx
Co-authored-by: Finnian Jacobson-Schulte <140328381+finnian0826@users.noreply.github.com>
This reverts commit 775a925.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6169 +/- ##
==========================================
- Coverage 88.86% 88.86% -0.01%
==========================================
Files 728 728
Lines 30997 31005 +8
Branches 5689 5695 +6
==========================================
+ Hits 27546 27553 +7
- Misses 3255 3256 +1
Partials 196 196
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
satish-ravi
reviewed
Oct 18, 2024
src/earn/EarnEnterAmount.tsx
Outdated
Comment on lines
289
to
291
| const rewardsPositions = useSelector(positionsWithBalanceSelector).filter((position) => | ||
| pool.dataProps.rewardsPositionIds?.includes(position.positionId) | ||
| ) |
There was a problem hiding this comment.
should we do the filter inside a useMemo?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Show line items for each reward that will be claimed
Also, only show Withdrawing and Claiming card if there are rewards that will be claimed
Test plan
Related issues
Backwards compatibility
Yes
Network scalability
If a new NetworkId and/or Network are added in the future, the changes in this PR will: