Consolidate API names related to Key #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
qmuntal
requested review from
setrofim,
thomas-fossati,
yogeshbdeshpande and
shizhMSFT
Codecov Report
@@ Coverage Diff @@
## main #161 +/- ##
==========================================
+ Coverage 93.59% 93.80% +0.20%
==========================================
Files 11 11
Lines 1687 1695 +8
==========================================
+ Hits 1579 1590 +11
+ Misses 75 72 -3
Partials 33 33
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
setrofim
approved these changes
Jul 24, 2023
|
@qmuntal : Thomas is on a long vacation. Please get the necessary comments from @shizhMSFT and then proceed with submission. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contain the following changes:
NewXKeytoNewKeyX, being X the key type. This form is more idiomatic.Keyprefix from Key properties. It is go-ish to avoid prefixing the name of a property with the name of the struct.XInvalidtoXReserved, being XKeyType,Curve,KeyOpandAlgorithm. This makes our API more similar to the COSE spec naming.