Apply OpenType MATH italic correction at run boundaries - #288
Open
Happypig375 wants to merge 3 commits into
Open
Apply OpenType MATH italic correction at run boundaries#288Happypig375 wants to merge 3 commits into
Happypig375 wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
InnerDisplaymutability semanticsThe behavior follows the OpenType MATH rule that the last glyph's italic correction is added when a slanted run is followed by a straight character: https://learn.microsoft.com/en-us/typography/opentype/spec/math#mathitalicscorrectioninfo-table
Validation
TestMeasure: 64/64 passedIssue32MatrixRightDelimiterSkia golden: passedgit diff --check: passedAllConstantValues: 572.205 ms mean (failed PR run: 29.294 s; local pre-fix warmup: 35.4 s; prior baseline: about 608 ms)QuarticSolutions: 131.028 ms mean (failed PR run: 344.7 ms; prior baseline: 122.4 ms)Stack
This is intentionally based on
port-iosmath-2026/ #264 because it builds on that port's math-run font-fusion semantics. The final performance repair isbcca7142.Fixes #32