-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bratseth/pack bits #32537
Bratseth/pack bits #32537
Conversation
No rush, but have you seen this @geirst ? |
Take your time @geirst ... :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 I am not sure if the new input / output type resolving in StatementExpression.doVerify() is tested by existing unit tests or if new tests should be added (especially error situations).
indexinglanguage/src/test/java/com/yahoo/vespa/indexinglanguage/expressions/ScriptTestCase.java
Outdated
Show resolved
Hide resolved
indexinglanguage/src/main/java/com/yahoo/vespa/indexinglanguage/expressions/AnyDataType.java
Show resolved
Hide resolved
Thanks! Yes, more work is needed on this type resolving for sure. This is just the bare minimum to support both embed and pack_bits in the same statement. |
@geirst please review.
Sorry for the many commits, this was a bit exploratory.
Now that we have contextual type resolving, I want to replace the earlier half-baked attempts at type resolving by it, but this diff is already large enough.