Bratseth/pack bits #32537
Merged
Bratseth/pack bits #32537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No rush, but have you seen this @geirst ? |
|
Take your time @geirst ... :-) |
geirst
previously approved these changes
Oct 21, 2024
indexinglanguage/src/test/java/com/yahoo/vespa/indexinglanguage/expressions/ScriptTestCase.java
Outdated
Show resolved
Hide resolved
indexinglanguage/src/main/java/com/yahoo/vespa/indexinglanguage/expressions/AnyDataType.java
Show resolved
Hide resolved
|
Thanks! Yes, more work is needed on this type resolving for sure. This is just the bare minimum to support both embed and pack_bits in the same statement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@geirst please review.
Sorry for the many commits, this was a bit exploratory.
Now that we have contextual type resolving, I want to replace the earlier half-baked attempts at type resolving by it, but this diff is already large enough.