Skip to content

Feat/comittee applications - #522

Merged
Paulijuz merged 12 commits into
mainfrom
feat/Comittee_applications
Aug 31, 2026
Merged

Feat/comittee applications#522
Paulijuz merged 12 commits into
mainfrom
feat/Comittee_applications

Conversation

@HaakonMikalsen

@HaakonMikalsen HaakonMikalsen commented Apr 14, 2026

Copy link
Copy Markdown
Contributor

Add comittee application view for comittee members

@HaakonMikalsen HaakonMikalsen linked an issue Apr 15, 2026 that may be closed by this pull request
@HaakonMikalsen
HaakonMikalsen marked this pull request as ready for review April 15, 2026 08:49
@HaakonMikalsen
HaakonMikalsen requested a review from Paulijuz April 15, 2026 12:28
Comment thread src/app/committees/[shortName]/periodes/[participationId]/page.module.scss Outdated
Comment thread src/app/committees/[shortName]/periodes/page.tsx Outdated
Comment thread src/app/committees/[shortName]/periodes/[participationId]/page.tsx Outdated
Comment thread src/services/applications/committeeParticipation/operations.ts Outdated
Comment thread src/services/applications/committeeParticipation/operations.ts Outdated
Comment thread src/app/committees/[shortName]/periodes/periodTableSection.tsx Outdated
…r side

fix: spelling, language error, empty code and html hydration error
@HaakonMikalsen

Copy link
Copy Markdown
Contributor Author

Thank you for all the feedback. I have unflattened the services, changed some names to be more clear, removed emty code and moved some checks to backend

@JohanHjelsethStorstad

Copy link
Copy Markdown
Member

I will take a look when I have time

@JohanHjelsethStorstad JohanHjelsethStorstad left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still strange

Comment thread src/app/committees/[shortName]/applicationPeriods/periodTableSection.tsx Outdated

@Paulijuz Paulijuz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very guuuud 🎉

@Paulijuz
Paulijuz self-requested a review August 31, 2026 18:01

@Paulijuz Paulijuz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgmt (agian)

@Paulijuz
Paulijuz dismissed JohanHjelsethStorstad’s stale review August 31, 2026 18:02

Everything looks resolved

@Paulijuz
Paulijuz merged commit 200b12c into main Aug 31, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat/Comittee applications

4 participants