Feat: Add BGP as an option for the Kube_VIP #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Feat: Add BGP as an option for the Kube_VIP * AB#9103388 * fix template name * fix template name
* Feat: Add BGP as an option for the Kube_VIP * AB#9103388 * fix template name * fix template name * removed whitespace
mnaser
requested changes
Oct 17, 2024
There was a problem hiding this comment.
This is a good start but I think personally we shouldn't have two templates, we should use the same template, but since we can have an if statement with Jinja for all the stuff using ARP and the other for BGP, which makes it easier to maintain long term and make sure that fixes apply properly both sides.
* Feat: Add BGP as an option for the Kube_VIP * AB#9103388 * fix template name * fix template name * removed whitespace * made changes per VexxHost Feedback * removed template * fixed variables
* Feat: Add BGP as an option for the Kube_VIP * AB#9103388 * fix template name * fix template name * removed whitespace * made changes per VexxHost Feedback * removed template * fixed variables * fixed template
whitespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feat: Add BGP as an option for the Kube_VIP
AB#9103388